search

logan-r / vilify

Unleash Your Inner Mad Scientist and Destroy the World (with Ice Cream) in this Open Source HTML5 Game
http://logan-r.github.io/vilify/
GNU General Public License v3.0
32 stars 25 forks source link

Sidebar #29

Closed sru closed 10 years ago

sru commented 11 years ago

Is it good idea to have separate sidebar outside of canvas element?

Graeme22 commented 11 years ago

I think it would b easier if it were in it.

logan-r commented 11 years ago

I vote for continuing keep the sidebar separate, because UI code is much easier when using HTML over something like the canvas API.

Graeme22 commented 11 years ago

k that’s fine. isnt the sidebar holding the current tiles and a couple other things?

sru commented 11 years ago

@Graeme22 Like Logan said, it's not easier if it were in it. I think it'd be more appropriate if it were in it. I think it'd be easier to sudden style changes if sidebar is in the canvas element.

Graeme22 commented 11 years ago

not necessarily. we can change html elements instantly using the innerHTML property. so I guess it really doesn’t matter. on the side or inside, either works.

ferndot commented 11 years ago

Do you want me to take this?

logan-r commented 11 years ago

Sure!

Maartenf commented 11 years ago

How has the sidebar been implemented? I want to work on it, but I couldn't find the code that adds it. I've searched all JS-files with the keyword "sidebar".

logan-r commented 11 years ago

The code was removed when the engine was redone.