search

loganasherjones / yapconf

Yet Another Python Configuration
http://yapconf.readthedocs.io/en/stable/
MIT License
18 stars 4 forks source link

Importing `open` from io package in Python 2 #35

Closed hazmat345 closed 6 years ago

hazmat345 commented 6 years ago

Fixes the issue with encoding being used with the builtin open in Python 2.

In the test it looks like builtins_path is only being used to specify how to mock out open, so I didn't feel super bad about just using it.

codecov-io commented 6 years ago

Codecov Report

Merging #35 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   95.54%   95.56%   +0.02%     
==========================================
  Files           4        4              
  Lines         628      631       +3     
  Branches      151      152       +1     
==========================================
+ Hits          600      603       +3     
  Misses         12       12              
  Partials       16       16
Impacted Files Coverage Δ
yapconf/spec.py 95.65% <100%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a33b925...0a4be6b. Read the comment docs.