search

loganasherjones / yapconf

Yet Another Python Configuration
http://yapconf.readthedocs.io/en/stable/
MIT License
18 stars 4 forks source link

DictItem apply_filter now excludes logger attribute from deep copy #99

Closed hazmat345 closed 4 years ago

hazmat345 commented 4 years ago

This PR fixes a test that was failing in the Python 2.7 and 3.6 Travis builds. It seems like the deepcopy was failing because it was trying to also copy the item's logger instance, which has an unpickable attribute. This PR excludes the logger from the deepcopy.

It also marks a test emoji as unicode so the test doesn't fail in Python 2.

codecov-io commented 4 years ago

Codecov Report

Merging #99 into master will increase coverage by 0.38%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   93.35%   93.73%   +0.38%     
==========================================
  Files           7        7              
  Lines        1083     1086       +3     
  Branches      235      236       +1     
==========================================
+ Hits         1011     1018       +7     
+ Misses         34       33       -1     
+ Partials       38       35       -3
Impacted Files Coverage Δ
yapconf/items.py 96.7% <100%> (+0.24%) :arrow_up:
yapconf/docs.py 90.57% <0%> (+0.72%) :arrow_up:
yapconf/spec.py 100% <0%> (+1.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f33076...7d9b878. Read the comment docs.