search

logankoester / errship

Errship is a Rails 3.1 engine for rendering error pages inside your layout. It supports i18n, custom exceptions, and Airbrake error tracking.
http://blog.logankoester.com/errship.html
MIT License
26 stars 5 forks source link

Breaks out ORM error rescuing into separate modules, moves internal testi #1

Closed hypomodern closed 13 years ago

hypomodern commented 13 years ago

Breaks out ORM error rescuing into separate modules, moves internal testing app to rails 3.1 final.

Logan, I'm interested in your feedback here. Here's the motivation: Apps that use an ORM other than ActiveRecord can't use errship as written since it hardcodes a rescue_from ActiveRecord::RecordNotFound. I thought about a config setting, then David suggested we just get modular up in this piece.

What do you think?

czarneckid commented 13 years ago

This looks good to me. Thanks for putting the pull request together after our discussion this AM.

logankoester commented 13 years ago

Very cool! I approve of this as version 2.0.0. Please run rake release when you get a chance. :-)