search

logankoester / errship

Errship is a Rails 3.1 engine for rendering error pages inside your layout. It supports i18n, custom exceptions, and Airbrake error tracking.
http://blog.logankoester.com/errship.html
MIT License
26 stars 5 forks source link

Conflict with omniauth #10

Open phuong-nguyen opened 12 years ago

phuong-nguyen commented 12 years ago

This route:

match '*address' => 'application#render_404_error' unless Rails.application.config.consider_all_requests_local

make omniauth stop working in our app as described in https://github.com/plataformatec/devise/wiki/OmniAuth:-Overview :

As of March, Omniauth now calls through to the app for dynamic configuration settings and you will need to define a route for /auth/:provider that results in a 404 so Omniauth knows how to proceed

The fix is to exclude /users/auth/:provider from the route (as described here: http://stackoverflow.com/questions/7365215/omniauth-devise-user-auth-facebook-magic-route-question): match "*path" => "application#render_404_error", :constraints => lambda {|req| !req.path.starts_with?("/users/auth/") } (in which user is the model that is omniauthable)

logankoester commented 12 years ago

@phuong-nguyen - How does this look? https://github.com/agoragames/errship/pull/13