search

logankoester / errship

Errship is a Rails 3.1 engine for rendering error pages inside your layout. It supports i18n, custom exceptions, and Airbrake error tracking.
http://blog.logankoester.com/errship.html
MIT License
26 stars 5 forks source link

explicitly state the format of the template #14

Closed fschwahn closed 11 years ago

fschwahn commented 12 years ago

Hi, this pull request includes one important fix and two minor ones:

  1. State the format explicitly when rendering the error-partial. The reason is that I was getting errors when a route with a format was accessed, such as "http://www.domain.tld/stylesheets/base.css". Rails was complaining that there was no view with an css extension it could render.
  2. I relaxed the bundler requirement as I'm using bundler 1.1.rc
  3. I took the hardcoded string for the errship_standard and make it i18n.
czarneckid commented 12 years ago

Looks good to me :+1: