Update MKL and LAPACK flags

loganoz / horses3d

HORSES3D: A high-order discontinuous Galerkin solver for flow simulations and multi-physics applications

https://loganoz.github.io/horses3d/

MIT License

112 stars 24 forks source link

Update MKL and LAPACK flags #119

Open Andres-MG opened 1 year ago

Andres-MG commented 1 year ago

Remove deprecation warning from ifort with -mkl flag, and separate MKL from LAPACK since MKL adds more functionality on top of LAPACK.

Closes #114.

loganoz commented 1 year ago

@Andres-MG, it seems the change is not compiling?

Andres-MG commented 1 year ago

Yes, I have been working on some other stuff and I couldn't finish this. I will try to go back to this and fix it this week hopefully.

Andres-MG commented 9 months ago

I think this PR can be closed without merging, the code works fine and the new testing strategy covers this better. Of course, we can keep it open if anyone wants to have a look.

loganoz commented 9 months ago

I took a look to the code while fixing the makefile. I am not sure that the code is perfect. I think that inside the code, MKL and LAPACK are sometimes interchanged. Let's keep the PR open, in case someone wants to take a look, but I agree it does not make sense to merge it now.