search

loganoz / horses3d

HORSES3D: A high-order discontinuous Galerkin solver for flow simulations and multi-physics applications
https://loganoz.github.io/horses3d/
MIT License
112 stars 24 forks source link

Compilation error in tools with HDF5 #129

Closed Andres-MG closed 1 year ago

Andres-MG commented 1 year ago

It seems that in the last modification of this part of the code https://github.com/loganoz/horses3d/blob/eca15f3fabc4d8b7b24b6c300abb26b2c6a23432/Solver/src/addons/tools/readHDF5.f90#L203 @stecolumbus added something that does not compile (at least in my laptop): corners is a vector of real(RP) and the function expects the IDs of the nodes as a vector of integer. I understand that we need to get the global indices of those corner nodes instead of calling the function with the coordinates directly, but I have never used that part of the code and I don't really know how it works.

stecolumbus commented 1 year ago

We’ll go back to the previously version of the master. Which compiler did you use? It works fine in my laptop. I’ll check it tomorrow.

Best, Stefano

Il giorno sab 21 gen 2023 alle 01:07 Andres-MG @.***> ha scritto:

It seems that in the last modification of this part of the code

https://github.com/loganoz/horses3d/blob/eca15f3fabc4d8b7b24b6c300abb26b2c6a23432/Solver/src/addons/tools/readHDF5.f90#L203 @stecolumbus https://github.com/stecolumbus added something does not compile (at least in my laptop): corners is a vector of real(RP) and the function expects the IDs of the nodes as a vector of integer. I understand that we need to get the global indices of those corner nodes instead of calling the function with the coordinates directly, but I have never used that part of the code and I don't really know how it works.

— Reply to this email directly, view it on GitHub https://github.com/loganoz/horses3d/issues/129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKOQA34VZHEME67E4EUYNQLWTMSFZANCNFSM6AAAAAAUCCDA54 . You are receiving this because you were mentioned.Message ID: @.***>

Andres-MG commented 1 year ago

I used gfortran, but in any case it seems that there is an actual bug there. Maybe we do not need to go back, but I don't know hard it will be to fix it.

loganoz commented 1 year ago

@Andres-MG, could you confirm that this bug is solved in current version of master?

stecolumbus commented 1 year ago

It should be fixed in the version I'm going to upload

Andres-MG commented 1 year ago

It is fixed in master because all the changes that Stefano did were reverted (including this). If he plans to push the changes again he will have to fix it, but from his last comment I understand that he has already done it.