search

loganoz / horses3d

HORSES3D: A high-order discontinuous Galerkin solver for flow simulations and multi-physics applications
https://loganoz.github.io/horses3d/
MIT License
112 stars 24 forks source link

Update keywords for iNS split forms #137

Closed Andres-MG closed 1 year ago

Andres-MG commented 1 year ago

There are some inconsistencies in the code regarding the split forms for the incompressible Navier-Stokes equations. With this PR, the split forms called skew-symmetric-1split and skew-symmetric-2split are now skew-symmetric 1 and skew-symmetric 2 everywhere.

Andres-MG commented 1 year ago

This is more complex than we expected. The tests are also failing for other reasons not related to the names of the averaging functions. Some of the control files seem to be wrong, and their names do not always match the ones in the workflow.

loganoz commented 1 year ago

I am aware of the naming problem of the control file in the workflow, I'll fix that. What about the other things? All fixed then?

Andres-MG commented 1 year ago

Everything seems to be fine with the last fix that you pushed. The control files were fine, just a silly mistake from my side... Now there is an issue with the VTKHDF module of horses2plt, but I will work on that on a different PR.

loganoz commented 1 year ago

@Andres-MG, the error we are getting is weird and doesn't seem to have anything to do with what you changed right?

Andres-MG commented 1 year ago

I think so. It seems that this test has not been run for some time, so I assume this issue is not new. The difference between the expected and the actual values is small, maybe it is not an error...

loganoz commented 1 year ago

I would bet it works with ifort and not with gfortran. I think that needs MKL, should it be even run with gfortran?

loganoz commented 1 year ago

BTW, it runs in flexo with ifort + mkl

Andres-MG commented 1 year ago

I think that this works with both, maybe the problem is that intel+MKL and gfortran use different implementations that return slightly different results.