search

loganoz / horses3d

HORSES3D: A high-order discontinuous Galerkin solver for flow simulations and multi-physics applications
https://loganoz.github.io/horses3d/
MIT License
106 stars 23 forks source link

Avoid assumed-rank arrays in MPI_Utilities #184

Closed Andres-MG closed 9 months ago

Andres-MG commented 9 months ago

Assumed-rank arrays were introduced in Fortran 2018, and many compilers and libraries seem to struggle with this feature. This PR implements the methods of MPI_Utilities.f90 with usual interfaces.

Closes #167

loganoz commented 9 months ago

@Andres-MG, once the conflicts are resolved, let me know so I can force the merge. Thanks

Andres-MG commented 9 months ago

All seems to be good now. I guess the errors are related to the gfortran+MKL issues we've seen before... How much should we increase the tolerance of those tests to get an OK?

loganoz commented 9 months ago

For now, I am skipping those test cases with gfortran. I think we need to further investigate the issue before increasing the tolerance

loganoz commented 9 months ago

@Andres-MG, the merge is finished. Delete the branch if you don't need it anymore. Thanks!