search

loganoz / horses3d

HORSES3D: A high-order discontinuous Galerkin solver for flow simulations and multi-physics applications
https://loganoz.github.io/horses3d/
MIT License
106 stars 23 forks source link

Implementation of non-3D meshes #194

Open Andres-MG opened 8 months ago

Andres-MG commented 8 months ago

The way 2D cases are handled is very confusing I think. These three attributes: https://github.com/loganoz/horses3d/blob/41111c597d0f88a22d067d586e025df629688482/Solver/src/libs/mesh/HexMesh.f90#L72-L74 are set during the pre-processing stage to a value that depends on the keywords in the control file and the mesh itself. It seems that this is done in this function: https://github.com/loganoz/horses3d/blob/41111c597d0f88a22d067d586e025df629688482/Solver/src/libs/mesh/HexMesh.f90#L1619 but it seems to override the choice of the user in the control file.

I will not merge #158 until this is reviewed, as the characteristic length of the elements is now wrong in 2D cases, and methods depending on it (LES, shock capturing) will provide different results.

loganoz commented 8 months ago

I have pinned this issue so we don't forget.