version 3.1.0 not work in Carthage

[wanewang]

I'm trying Genome with Carthage, but when running carthage update it won't download Packages folder content. Node, PathIndexable and Polymorphic is missing in project, which caused built failed.

I'm now running with specific version github "LoganWright/Genome" == 3.0.3 It worked.

might be submodule issue?

[loganwright]

@jhihguan I honestly have no idea 🙊 I'm not up and up on Carthage.

Would deleting the .git folders in Packages help perhaps?

[wanewang]

I don't see .git in Packages folder.

When I clone the project in SourceTree it will error with fatal: No url found for submodule path 'Packages/Node-1.0.1' in .gitmodules and if I type git submodule in terminal, it will show fatal: no submodule mapping found in .gitmodules for path 'Packages/Node-1.0.1'

But when I try pod install in another project, those package will download correctly.

yeah...I'm not up on Carthage😆

[max-potapov]

Got same git error with SPM:

$ swift build
Cloning https://github.com/LoganWright/Genome.git
/Users/max/.homebrew/bin/git clone --recursive --depth 10 https://github.com/LoganWright/Genome.git /Users/max/devel/***-swift/Packages/Genome.git
Cloning into '/Users/max/devel/***-swift/Packages/Genome.git'...
fatal: No url found for submodule path 'Packages/Node-1.0.1' in .gitmodules

error: Failed to clone https://github.com/LoganWright/Genome.git to /Users/max/devel/***-swift/Packages/Genome.git

[loganwright]

@jhihguan @max-potapov can you attempt 3.1.1 and let me know if the issue is resolved.

[wanewang]

I'm testing it in https://github.com/bwhiteley/JSONShootout if I change version to 3.1.1 and do carthage update --no-build theGenome.xcodeproj still link to order version of Node Polymorphic PathIndexable see the screenshot below

strange carthage...

[max-potapov]

@LoganWright tried 3.1.1 with spm and git recursive clone – everything is fine. thanks!

[wanewang]

ahh, I think I found the issue, because carthage will use source code's Genome.xcodeproj to build project. But right now Node Polymorphic PathIndexable is point to old code which is not existed anymore. (you can see my screenshot above)

I know how to add file into project, but I don't know how to link file like the way you did ex. Core/Node+Init.swift. Can you also tell me how you do that?

[loganwright]

@jhihguan I was regenerating project from SPM, normally I wouldn't include the xcodeproj in the repository, but its necessary for Carthage. Let me try a regen and see what happens.

[loganwright]

@jhihguan how does #79 look?

[loganwright]

@jhihguan @max-potapov can you guys try 3.1.2 🙏

[wanewang]

@LoganWright it works! maybe after @max-potapov confirmed than this issue can be closed

[wanewang]

@LoganWright sorry... I found a small issue that 3.1.2 only build Mac device while 3.0.3 has Mac, iOS, watchOS, tvOS

[wanewang]

I add platform support in #80 and also set the minimum version for each platform

[max-potapov]

@jhihguan @LoganWright both spm & carthage works fine with 3.1.2!

[loganwright]

@jhihguan thanks, merged as 3.1.3

https://github.com/LoganWright/Genome/releases/tag/3.1.3

[wanewang]

great! it works