loganwright / SimpleChat

An Easy To Use Bubble Chat Interface
Mozilla Public License 2.0
262 stars 53 forks source link

I found an issue for Japanese or Chinese keyboard.. #1

Closed donobono closed 10 years ago

donobono commented 10 years ago

Thank you for sharing cool source!!

I found an issue for Japanese or Chinese keyboard. If you test with Japanese(kana) keyboard, you can find it.

in keyboardWillShow method, you're using

NSValue* keyboardFrameBegin = [keyboardAnimationDetail valueForKey:UIKeyboardFrameBeginUserInfoKey];

but I think you should use UIKeyboardFrameEndUserInfoKey instead of UIKeyboardFrameBeginUserInfoKey.

It works well for me, but I don't know it cause other trouble. Please check it..

Thank you~

loganwright commented 10 years ago

I was able to replicate the issue, and fix it with your current suggestion. Thanks for providing an easy fix, and I'm glad you like it!

Let me know if there's anything else you need to close this issue.

Best,

Logan

donobono commented 10 years ago

Thanks for fast answer.. :-)