logaretm / villus

🏎 A tiny and fast GraphQL client for Vue.js
https://villus.dev
MIT License
790 stars 31 forks source link

missing null in type of useMutation #182

Closed sumtiogo closed 1 year ago

sumtiogo commented 1 year ago

after install villus@2.0.1, villus.d.ts in package shows

declare function useMutation<TData = any, TVars = QueryVariables>(query: Operation<TData, TVars>['query'], opts?: Partial<MutationExecutionOptions>): {
    data: Ref<TData>;
    isFetching: Ref<boolean>;
    isDone: Ref<boolean>;
    error: Ref<CombinedError>;
    execute: (variables?: TVars) => Promise<{
        data: TData;
        error: CombinedError;
    }>;
};

but it should be

declare function useMutation<TData = any, TVars = QueryVariables>(query: Operation<TData, TVars>['query'], opts?: Partial<MutationExecutionOptions>): {
    data: Ref<TData | null>;
    isFetching: Ref<boolean>;
    isDone: Ref<boolean>;
    error: Ref<CombinedError | null>;
    execute: (variables?: TVars) => Promise<{
        data: TData | null;
        error: CombinedError | null;
    }>;
};
logaretm commented 1 year ago

You are absolutely correct. I will fix this in a few minutes.