search

logdna / logdna-agent-v2

The blazingly fast, resource efficient log collection client
https://logdna.com
MIT License
65 stars 46 forks source link

Add nodeSelector to Helm chart #130

Open mogopz opened 3 years ago

mogopz commented 3 years ago

Hi, I was going to make a PR to add this myself but this repo doesn't seem to actually contain the Helm repo source (I'm looking at https://assets.logdna.com/charts). If the Helm code is public and you can point me to the right location I'm happy to raise a PR for this.

It would be useful to have a nodeSelector added to the DaemonSet manifest. At the moment your official LogDNA Docker images don't support ARM and since we run a cluster with a mixture of amd64/arm64 instances we need a way to specify which nodes to run on.

jorgebay commented 3 years ago

Hi @mogggggg ! The repo that generates the helm charts is currently private. It's currently just a port of the original helm chart at the deprecated "stable" repo.

There's an internal follow-up ticket for revamping the Helm charts to include stuff like the ability to set the securityContext.

Adding a nodeSelector makes sense, I've include it in our internal ticket.

Let's keep this issue open and we'll post any update here.

mogopz commented 2 years ago

Has there been any progress on this?

mohitthakur3 commented 6 months ago

Hey Team,

I am also struggling to add ¸ parameter, and this very important. In our Kubernetes cluster we have some nodes with Taint, and our requirement is just to install the agent on the nodes that is having taint. But right now it deploy the agent on those nodes as well which is not having any taint or tolerations. To fix this problem we need to add nodeSelector with tolerations. So as I see logdna chart not having parameter we can set this.

Please fix this issue ASAP.

@logdnabot

Thanks.