search

logdna / logdna-agent

LogDNA Agent streams from log files to your LogDNA account. Works with Linux, Windows, and macOS Servers
https://logdna.com
MIT License
138 stars 55 forks source link

lint: update eslint dependency #180

Closed smusali closed 4 years ago

smusali commented 4 years ago

@matt-march, @jakedipity, can you take a look at this? Thanks!

jakedipity commented 4 years ago

Is our @answerbook publicly available? If not we might need to reconsider this.

smusali commented 4 years ago

Is our @answerbook publicly available? If not we might need to reconsider this.

I set the GITHUB_PACKAGES_TOKEN environment variable to be used by CircleCI - considering the environment variables are not public here, is there any other concern? + it's saved as a part of devDependencies; so, whenever we release a new version, we should do npm install --production which doesn't include eslint, etc.

smusali commented 4 years ago

@jakedipity, can you do another round of review here, please, if possible? Thanks!

darinspivey commented 4 years ago

Commit titles for dependency updates should read like this:

deps: @answerbook/eslint-config-logdna@5.0.0
matt-march commented 4 years ago

Is our @answerbook publicly available? If not we might need to reconsider this.

I set the GITHUB_PACKAGES_TOKEN environment variable to be used by CircleCI - considering the environment variables are not public here, is there any other concern? + it's saved as a part of devDependencies; so, whenever we release a new version, we should do npm install --production which doesn't include eslint, etc.

I imagine anyone that's not part of @answerbook will get a bunch of errors if the clone the repo, wouldn't they?

darinspivey commented 4 years ago

Is our @answerbook publicly available? If not we might need to reconsider this.

I set the GITHUB_PACKAGES_TOKEN environment variable to be used by CircleCI - considering the environment variables are not public here, is there any other concern? + it's saved as a part of devDependencies; so, whenever we release a new version, we should do npm install --production which doesn't include eslint, etc.

I imagine anyone that's not part of @answerbook will get a bunch of errors if the clone the repo, wouldn't they?

Yep, true, we should not have any private packages in here. We could probably make our linter public-facing, but I don't think we have a public registry properly set up for that yet (it's a bit out of scope here). At this point, we could just update the instructions to tell people to npm install --production, which would skip that dev dependency. They probably wouldn't be able to run tests though. Not sure what's best.