search

logdna / logdna-agent

LogDNA Agent streams from log files to your LogDNA account. Works with Linux, Windows, and macOS Servers
https://logdna.com
MIT License
138 stars 55 forks source link

test: Add `tap` as the test framework along with some starter tests #186

Closed darinspivey closed 4 years ago

darinspivey commented 4 years ago

test: Add tap as the test framework along with some starter tests

We are moving to tap as a testing framework. This commit converts the getFiles() test from Jest to tap, and adds the start of more tests. The goal will be to eventually have some integration tests here.

Semver: patch Ref: LOG-6026

style(linter): Change linter styles

This changes aligns with our other repos, namely a 2-space indent.

Semver: patch Ref: LOG-6026

darinspivey commented 4 years ago

Overall, looks good considering the most of these changes are the linting changes - since you have already touched and linted all of those files, can you make sure to replace var with let and/or const depending on how it gets used? The next version is gonna get compiled / built using Node v8.3.0 in which there is full support for let.

There is plans to refactor later, and I don't think we should mix efforts, ie. don't do code changes on top of linting changes. We want the code changes to stand on their own commit, and that can be part of the next code refactor for this (which, honestly is up in the air at this point since there's talk about sunsetting the node version of the agent).