search

logdna / logdna-cli

The LogDNA CLI allows you to signup for a new account and tail your server logs right from the command line.
https://logdna.com
MIT License
27 stars 21 forks source link

Search sends wrong query param for query #15

Closed rhart closed 5 years ago

rhart commented 6 years ago

The query supplied with a search command is ignored and all lines returned. I think this is because the wrong query param is being set.

The documentation (https://docs.logdna.com/docs/v1-export-api) specifies that it should be query, but I believe it is being sent as q https://github.com/logdna/logdna-cli/blob/master/index.js#L314

stuckj commented 6 years ago

Yep, this definitely looks wrong. Kinda makes the search feature of the CLI not at all useful.

stuckj commented 6 years ago

PR opened above that addresses this. Also note that if you want to compile this locally you need to use node < 8 when you install nexe and install < version 2 of nexe (I used nexe@1.1.6) due to a bug introduced in a dependency of nexe (see here: https://github.com/nexe/nexe/issues/454). Also, in case you're not familiar with grunt, make sure to install grunt-cli globally. E.g., use node < 8 (with nvm it's easy) and do npm install -g nexe@1.1.6 grunt-cli.

smusali commented 5 years ago

Thanks, @stuckj! You Pull Request was already merged on May 29th.