search

logdna / logdna-cli

The LogDNA CLI allows you to signup for a new account and tail your server logs right from the command line.
https://logdna.com
MIT License
27 stars 21 forks source link

Multiple dependencies incompatible with current nodejs LTS release #27

Closed mgabeler-lee-6rs closed 4 years ago

mgabeler-lee-6rs commented 5 years ago

The 1.x version of bufferutil in use does not work for node 10.x:

make: Entering directory '/home/mgl/3psrc/logdna-cli/node_modules/utf-8-validate/build'
  CXX(target) Release/obj.target/validation/src/validation.o
In file included from ../../nan/nan.h:190:0,
                 from ../src/validation.cc:15:
../../nan/nan_maybe_43_inl.h: In function ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’:
../../nan/nan_maybe_43_inl.h:88:15: error: ‘class v8::Object’ has no member named ‘ForceSet’
   return obj->ForceSet(GetCurrentContext(), key, value, attribs);
               ^~~~~~~~

Updating the bufferutil and utf-8-validate dependency to the current release addresses this, but I don't know if that "works" because it now insists on running as root, which is not viable in my environment.

smusali commented 5 years ago

Hey @mgabeler-lee-6rs, this bufferutil issue is widely known one and right now, it works well on node@6.10.2 and npm@6.4.1 - but you are right, it should be fixed universally and bufferutil version should be updated from v1 to latest in our package.json.

Let me work on and test this! I will let you know here by the end of today!

Thanks again!

smusali commented 4 years ago

it's already been fixed!