Refactor and add tests - Githubissues

logdna / logdna-cloudwatch

AWS Lambda for logging from CloudWatch into LogDNA

MIT License

12 stars 19 forks source link

Refactor and add tests #20

Closed vilyapilya closed 4 years ago

vilyapilya commented 4 years ago

abstract constants and log creating logic to their own files
add tests
modify circelci commands to make sure they don't modify package.json when installing dev dep (looks like npm default is to save them to the package.json)
add eslint-jest plugin

vilyapilya commented 4 years ago

@smusali classes usually used when the instances are used multiple times and we need sort of a encapsulation for each instance. Classes also are heavier than modules. In this project CloudWatch and other libraries won't create multiple instances so creating an es class for it will not be very optimal and correct.