Closed smusali closed 4 years ago
Any possibility to add some tests in here?
Also, looks like the CircleCI workflow isn't hooked up to the PR.
@matt-march, CircleCI
has been hooked up but it does just linting check - will add tap
tests today.
@jakedipity @matt-march, tested this new Lambda
function, it works as expected.
This is when LOG_RAW_EVENT
is not enabled:
And this is when LOG_RAW_EVENT
is enabled:
I will add the unit tests in Tap
today.
@matt-march, @jakedipity, added tap
unit testing coverage as well:
@jakedipity, @matt-march, can you do another round of review here? Thanks!
@jakedipity, @matt-march, can you do another round of review here? Thanks!
The growing number of customers have started requesting the possibility of sending the raw event messages in the
line
field instead of having a custom payload.Handling the new environment variable is implemented in the same way as handling
LOGDNA_EVENTLOG
andLOGDNA_FILELOG
inlogdna/logdna-s3
In addition to that change, the following changes have been included in this
Pull Request
:LICENSE
README
CHANGELOG
tap
unit testing coverage