search

logdna / logdna-winston

LogDNA's Node.js logging module with support for Winston
MIT License
16 stars 14 forks source link

Create type definition #19

Open Sytten opened 4 years ago

Sytten commented 4 years ago

Fixes https://github.com/logdna/logdna-winston/issues/18

Sytten commented 4 years ago

@smusali if you have time to review

Sytten commented 4 years ago

Just a little ping to get some feedback, thanks!

Sytten commented 4 years ago

Another ping just to make sure I am not forgotten @smusali @jakedipity

Sytten commented 4 years ago

@smusali Let me know if you prefer that I copy the props from the parent, otherwsie feel free to merge.

Sytten commented 4 years ago

Dear @smusali, I hope you will the changes to you liking. Please see my comment above concerning a potential bug with defaults. I am also starting to consider that maybe the options interface should not inherit from the parents since it's particular mix of both (the case of level is problematic for example).

smusali commented 4 years ago

Dear @smusali, I hope you will the changes to you liking. Please see my comment above concerning a potential bug with defaults. I am also starting to consider that maybe the options interface should not inherit from the parents since it's particular mix of both (the case of level is problematic for example).

That's fine! I'll have a couple of requests as well

Sytten commented 4 years ago

@smusali I think it would be best if you take over, I do not have the bandwidth to go back and forth over this issue anymore. Thanks!

TrejGun commented 3 years ago

@smusali can you please merge this?