search

logdna / logger-node

A nodejs logger client for LogDNA
MIT License
34 stars 17 forks source link

fix: Turn off maxBodyLength in Axios #46

Closed darinspivey closed 3 years ago

darinspivey commented 3 years ago

Axios has a maxBodyLength which defaults to 2000 bytes. Given that the payloads for the logger can be much larger than this, turn this limitation off. It should be noted that there's only 1 report of this in the wild, and the problem has not been able to be reproduced.

Semver: patch Fixes: https://github.com/logdna/logger-node/issues/44

darinspivey commented 3 years ago

LGTM, I think it makes more sense to lean on FLUSH_BYTE_LIMIT here anyway

Yes it does, although we shouldn't have to mess with that much. I'm using 1MB payloads and can't re-produce the error. In any case, we don't need Axios limiting us here.