search

logdna / nodejs

Node.js library for logging to LogDNA
MIT License
74 stars 66 forks source link

flushAll callback never called #37

Closed dansgithubuser closed 6 years ago

dansgithubuser commented 6 years ago

https://github.com/logdna/nodejs/blob/master/lib/logger.js#L238

should be if (--expectedCallbacks < 1) cb(); or if (expectedCallbacks-- <= 1) cb();

respectus commented 6 years ago

Hmm that's weird what version of node are you using? I haven't tested this flushAll extensively, I've pushed a fix to npm logdna version 2.0.4. Do let me know if that works, thanks.

dansgithubuser commented 6 years ago

Was using version 2.0.2. All seems in order now. Thanks for the fast response!