search

logdna / nodejs

Node.js library for logging to LogDNA
MIT License
74 stars 66 forks source link

Fixes callback being called immediately after `flushAll` #76

Closed guidolodetti closed 4 years ago

guidolodetti commented 5 years ago

flushAll callback is called immediately, and it doesn't wait for all the flushes to be completed. This commit waits for all the flush callbacks to be completed and then completes the final callback.

vilyapilya commented 5 years ago

@guidolodetti thank you for adding the fix. Could please also modify the tests so they pass and work with the changes in this PR. You can run the tests by executing npm test but make sure that you're using node 10.

guidolodetti commented 5 years ago

Hi! Sorry but I cant’t find the time for this.

El El mié, 23 oct 2019 a las 21:58, vilyapilya notifications@github.com escribió:

@guidolodetti https://github.com/guidolodetti thank you for adding the fix. Could please also modify the tests so they pass and work with the changes in this PR.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/logdna/nodejs/pull/76?email_source=notifications&email_token=ABV4L3ZFUUAV6R53HVF5IGTQQCUEZA5CNFSM4JBZ3M6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECCVYLY#issuecomment-545610799, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV4L336BT3FTV4VWLFJUSDQQCUEZANCNFSM4JBZ3M6A .

vilyapilya commented 5 years ago

@guidolodetti could you please remove afterEach block from the testing block. (see Fix the tests so they don't fail with the updates in https://github.com/logdna/nodejs/pull/76 #82). So we can merge your pull request.