search

logdna / python

A python package for sending logs to LogDNA
MIT License
47 stars 35 forks source link

refactor: clean up and introduce thread workers #70

Closed smusali closed 3 years ago

smusali commented 3 years ago

ci: cleaning on automation

Semver: patch

refactor: reduce code complexity

Semver: patch

feat(threadWorkerPools): introduce extra threads

In order to provide non-blocking I/O, introducing ThreadWorkerPools for multiple parts and imitating the non-blocking I/O implementation from our Ruby library.

Semver: minor

test(logger): modify testing for logger

Semver: patch

feat(meta): enable adding custom meta fields

This commit introduces a new option called custom_fields similar to tags and also new default meta fields: lineno, name, pathname, args, etc.

Semver: minor

docs: update the README as requested

Semver: patch

teeohhem commented 3 years ago

Overall, nice work! This has a lot of great changes. I've added a few comments to improve some things. Also, we'll need a ticket to restore some of the integration test functionality. The unit tests only cover so much.

smusali commented 3 years ago

@tanberry, updated as you requested!

smusali commented 3 years ago

These changes are for resolving and/or improving #61, #59, #58, and #56.