Gem causes all rake tasks to exit with non-zero code which falsely indicates an error

logdna / ruby

Ruby library for logging to LogDNA

MIT License

17 stars 20 forks source link

Gem causes all rake tasks to exit with non-zero code which falsely indicates an error #2

Closed masha256 closed 7 years ago

masha256 commented 7 years ago

https://github.com/logdna/ruby/blob/830fa833fcb651fd69fc60e4efb91b94319db711/lib/logdna.rb#L201

With the above line, any rake task in my application that loads this gem will exit with an exit code of 1, making my CI system think the command failed.

Suggest removing the

exit!

line and just letting the at_exit hander clean up @@client and not mess with the exit status.

respectus commented 7 years ago

Hi @machadolab,

Thanks for bringing this issue to our attention, I've taken a look and it does seem like this line is unnecessary. I've removed it from version 1.1.1 of the gem. Please do let me know if you experience any issues with the latest version. Do appreciate the feedback!