search

logdna / terraform-provider-logdna

Terraform provider to simplify creation of views, preset alerts and other resources in LogDNA!
https://registry.terraform.io/providers/logdna/logdna/latest
MIT License
11 stars 12 forks source link

feat(view): Implement resourceViewRead #15

Closed darinspivey closed 3 years ago

darinspivey commented 3 years ago

chore(channels): Refactor the function that creates outgoing JSON

The buildChannels function is explicitly for outgoing JSON, but that isnt't very clear. It is also a long function, making it messy to add new integrations in the future. This change refactors it into a more abstracted version, and into a new file.

Semver: patch

chore(errors): Cleanup errors to be more valuable

Rather than returning a single error, we should let diag.Diagnostics aggregate the errors to all be reported at once. This style also allows us to put more context around each error.

Semver: patch

chore(types): organize request and response body types

Having all of the types in client.go felt wrong. Splitting them into separate files for request and response helps us keep track of the varying datatypes and minimize confusion. It also made it easier/appropriate to add methods to those types for data processing.

Semver: patch

feat(view): Implement resourceViewRead

To be able to honor changes made to resources through APIs outside of Terraform, we must implement the "read resource" and update TF's state for the result.

This change also refactors slightly the "client" slightly to more easily accommodate generic calls.

Ref: LOG-9567

darinspivey commented 3 years ago

Closing this in favor of a feature branch merge