search

logdna / terraform-provider-logdna

Terraform provider to simplify creation of views, preset alerts and other resources in LogDNA!
https://registry.terraform.io/providers/logdna/logdna/latest
MIT License
11 stars 12 forks source link

feat(ingestion): ingestion exclusion rule as a resource #32

Closed jorgebay closed 3 years ago

jorgebay commented 3 years ago

Expose a logdna_ingestion_exclusion resource to manage ingestion exclusions for an account.

Ref: LOG-10494 Semver: minor

jorgebay commented 3 years ago

Integration tests against prod are failing because ingestion exclusion rules management is not yet in prod, it should be good to be reviewed though.

jorgebay commented 3 years ago

Thanks @david-ly & @mdeltito for the review, I'll update them soon.

Mike! I've based mostly on your implementation, it was simple to follow so kudos to you :)

jorgebay commented 3 years ago

I've rebased and updated it to have the title field as optional.

Tests are failing on Jenkins but passing with the dev version of the API. In the meantime, it's ready to be reviewed.

jorgebay commented 3 years ago

I've rebased it to solve the conflicts, CI is now green after exclusion rules mgmt is available on the API.