Closed dm36 closed 4 years ago
@nimbinatus reformatted the Terraform docs to italicize optional and required, default be consistently at the end and to give type info.
@michaelshi-logdna updated 30s -> 30 for triggerintervals.
@tanberry Have added the pre-requirements and considerations as well as the updates to the README.
please have another look :) thank you!
can we add the coveralls badge to the README since you already set it up? 🎉
@tanberry was referencing this section here at the bottom of https://github.com/logdna/terraform-provider-logdna/blob/78dc74c123bb812a783d2457bd8cb7e161fd8a19/docs/index.md:
The following arguments are supported:
servicekey
: (Required) LogDNA Account Service Key. This can be generated or retrieved from Settings > Organization > API Keysurl
: (Optional) Default: api.logdna.com The LogDNA region URL. If you’re configuring an IBM Log Analysis with LogDNA or IBM Cloud Activity Tracker with LogDNA you’ll need to ensure url
is set to the right endpoint depending on the IBM regionA few comments/feedback on the TF readme.io docs: — I’m waiting for a sync to complete to make sure our examples work.
The example code gives the version 1.0.0 but that hasn’t been released yet so we should put in 0.0.1 we should add the terraform init, terraform plan and terraform apply commands to teach users who are not familiar with TF
fwiw the intent is that we will launch with a 1.0.0 so having examples prepped for that helps make sure we don't accidentally sneak in a 0.0.1 outdated reference on launch
Makes updates to the README and docs such as pluralizing category. Additionally makes code changes to comply with the categories update
Ref: LOG-7687 Semver: Patch