search

logdna / terraform-provider-logdna

Terraform provider to simplify creation of views, preset alerts and other resources in LogDNA!
https://registry.terraform.io/providers/logdna/logdna/latest
MIT License
11 stars 12 forks source link

feat: Adding Webhooks to Index Rate Alert #87

Closed arani-sen closed 1 year ago

arani-sen commented 1 year ago

adding the ability to add webhooks for Index Rate Alerts

Ref:LOG-9667

arani-sen commented 1 year ago

I believe we should get #88 merged first so that you can run go fmt ./... on your branch and see minimal changes. Or, we can ignore my comments about formatting and I'll rebase my PR after this one has merged.

But before either can be merged we need @jakedipity to answer a question I have put to him in Slack about the failing tests.

I wanted to wait for your merge first so that i can run my format as well. I will rebase once your pr is merged.

seeruyy commented 1 year ago

It looks good to me now, but we still have an issue with Key API test which is not related to this PR. @jakedipity Could you please assist with this issue?

arani-sen commented 1 year ago

It looks good to me now, but we still have an issue with Key API test which is not related to this PR. @jakedipity Could you please assist with this issue?

This fix is related to the issue https://github.com/answerbook/logdna-api/pull/825