search

logfellow / logstash-logback-encoder

Logback JSON encoder and appenders
Apache License 2.0
2.44k stars 407 forks source link

Support max length setting on exception message (to be used with ShortenedThrowableConverter.maxLength) #1013

Open gauravsaralMs opened 8 months ago

gauravsaralMs commented 8 months ago

Is your feature request related to a problem? Please describe. Currently if ShortenedThrowableConverter.maxLength is set to any value (say 1000) then that includes the exception message as well as stack trace length. In case someone adds a large/dynamic exception message then it is possible that the whole stack trace is lost.

Describe the solution you'd like proposal is to include a setting ShortenedThrowableConverter.maxErrorMessageLength which can be used to limit the length of error message being included. So with maxErrorMessageLength set as 100 and maxLength set as 1000 it can be guaranteed that 900 limit will be used for stack traces.

Describe alternatives you've considered N/A

Additional context N/A

gauravsaralMs commented 7 months ago

@philsttr gentle ping to please take a look at this issue.

I am open to contributing this feature but want to confirm that this feature sounds good be added.

philsttr commented 3 months ago

Sounds good to me. Contributions welcome

a1shadows commented 2 months ago

Can I take this up if no one else is?