search

loggi / loggibud

Real-world benchmarks for urban delivery problems, including vehicle routing and facility location problems.
MIT License
177 stars 31 forks source link

Add support to pass OSRM configurations in the `evaluate_solution` function #20

Closed fillipe-gsm closed 3 years ago

fillipe-gsm commented 3 years ago

When running the OSRM server with different configurations than the default ones, we can usually call the function with something like:

from loggibud.v1.distances import calculate_distance_matrix_m, OSRMConfig

config = OSRMConfig(host="new-address")
distance_matrix = calculate_distance_matrix_m(points, config)

However, in the evaluation_solution function from loggibud.v1.eval.task1, we are stuck with the default parameters as it has no way of receiving this config variable:

image

I created this issue for us to determine a good approach for handling it.

Maybe simply add this config variable as an input parameter to evaluate_solution?

gabisurita commented 3 years ago

Adding the config as an additional parameter sounds reasonable.