search

loggi / loggibud

Real-world benchmarks for urban delivery problems, including vehicle routing and facility location problems.
MIT License
177 stars 31 forks source link

Broken links to IPEA gpkg files #24

Closed ropinho closed 3 years ago

ropinho commented 3 years ago

All links to download geographic data from IPEA is broken returning 404 (Not Found).

Hence, the generation pipeline described in instance generation README.md finish unsuccessfully. The generate.py script fails to find the *.gpkg files in the data_raw directory, raising following error:

fiona._err.CPLE_OpenFailedError: ./loggibud/loggibud/v1/instance_generation/../../../data_raw/33.gpkg: No such 
file or directory

The (broken) links used in download.sh script are:

gabisurita commented 3 years ago

Thanks for the report. I believe IPEA changed the path internally. I'll investigate this further.

minterciso commented 3 years ago

I'm also experiencing this issue, will this be updated soon?

gabisurita commented 3 years ago

By checking the metadata from IPEA (available at this CSV), I believe that the new paths are:

https://www.ipea.gov.br/geobr/data_gpkg/census_tract/2010/33census_tract_2010.gpkg https://www.ipea.gov.br/geobr/data_gpkg/census_tract/2010/53census_tract_2010.gpkg https://www.ipea.gov.br/geobr/data_gpkg/census_tract/2010/15census_tract_2010.gpkg

But I couldn't validate if anything else changed, and the rest of the pipeline still works. @pinho @minterciso Maybe you can check if just changing the paths and renaming the files work. I shall check this in a couple of days.

ropinho commented 3 years ago

@gabisurita I used these links to manually download the files (using curl) and placed them into the data_raw directory. The instances were generated successfully.

Therefore, I believe that replace the links in "download.sh" fix this issue. I can test this and open a PR if all OK.

gabisurita commented 3 years ago

Solved by #28 .

gabisurita commented 3 years ago

We should also fix the README links, but I'll keep this closed since the script is already working.