search

loggly / loggly-jslogger

Client-side (browser) logger to use with Loggly v2
79 stars 52 forks source link

Bower deployment #4

Closed ppcano closed 9 years ago

ppcano commented 10 years ago

would it be possible that the library can be deployed with bower?

mostlyjason commented 10 years ago

Yeah we can work on getting it up on bower

mostlyjason commented 10 years ago

Looks like someone added already. Have you looked at using one of these? http://bower.io/search/?q=loggly

ppcano commented 10 years ago

@mostlyjason , this search only shows two angular packages angular-loggly and angular-loggly-logger, instead of this repo.

mostlyjason commented 10 years ago

Yeah I was hoping those might work since they are wrappers for this library and already include it. It sounds like you prefer this version without angular?

On 9/24/2014 10:59 PM, Pepe Cano wrote:

@mostlyjason https://github.com/mostlyjason , this search only shows two angular packages angular-loggly https://github.com/GoAugust/angular-loggly and angular-loggly-logger https://github.com/ajbrown/angular-loggly-logger, instead of this repo.

— Reply to this email directly or view it on GitHub https://github.com/loggly/loggly-jslogger/issues/4#issuecomment-56776977.

ppcano commented 10 years ago

Yes, this repository

El 25/09/2014, a las 08:31, Jason Skowronski notifications@github.com escribió:

Yeah I was hoping those might work since they are wrappers for this library and already include it. It sounds like you prefer this version without angular?

On 9/24/2014 10:59 PM, Pepe Cano wrote:

@mostlyjason https://github.com/mostlyjason , this search only shows two angular packages angular-loggly https://github.com/GoAugust/angular-loggly and angular-loggly-logger https://github.com/ajbrown/angular-loggly-logger, instead of this repo.

— Reply to this email directly or view it on GitHub <https://github.com/loggly/loggly-jslogger/issues/4#issuecomment-56776977 .

— Reply to this email directly or view it on GitHub https://github.com/loggly/loggly-jslogger/issues/4#issuecomment-56778857.

varshneyjayant commented 10 years ago

@ppcano We have added a new package loggly-jslogger. You can now use this package to deploy Loggly's jslogger using Bower.

ppcano commented 10 years ago

@psquickitjayant, although the package is available for bower import, I missed a bower file which manage the library release version.

Currently the library is importing as:

    "loggly-jslogger": "latest",

In this case, any new release may automatically be updated and it may break the loggly app functionality.

Please, may you manage the loggly-jslogger release process.

ppcano commented 9 years ago

@psquickitjayant ping.

May the bower.json file be added to the repository including the current loggly-jslogger version.

varshneyjayant commented 9 years ago

@ppcano Sure, I will add it.

barlindhaug commented 9 years ago

You need to git tag your releases to get a versioned bower dependency.

Right now I have to use

"loggly-jslogger": "*"

instead of

"loggly-jslogger": "1.1.0"
varshneyjayant commented 9 years ago

@barlindhaug if you see latest package, it has the version.

ppcano commented 9 years ago

@psquickitjayant, setup the version on the bower.json file does NOT work

    "loggly-jslogger": "2.0.0",

As @barlindhaug commented, it could be that you need to git tag your releases.

varshneyjayant commented 9 years ago

@ppcano You are right, I forgot to do that. I will take care from my next release. I am making few more changes in the library. I will make sure to tag the commit.

davidgovea commented 9 years ago

+1 for tagging releases, "loggly-jslogger": "*" makes me uneasy. :+1:

"loggly-jslogger": "#c293114921" works in the meantime

varshneyjayant commented 9 years ago

@mostlyjason this can be closed as the library is on Bower with versions tagged.

davidgovea commented 9 years ago

@psquickitjayant @mostlyjason I see no versions tagged.

Here is the output from "bower info loggly-jslogger" ... No versions available.

% bower info loggly-jslogger 
bower not-cached    git://github.com/loggly/loggly-jslogger.git#*
bower resolve       git://github.com/loggly/loggly-jslogger.git#*
bower checkout      loggly-jslogger#master
bower resolved      git://github.com/loggly/loggly-jslogger.git#c293114921

{
  name: 'loggly-jslogger',
  homepage: 'https://github.com/loggly/loggly-jslogger',
  description: 'A Javascript client to send logs to Loggly.',
  main: 'src/loggly.tracker.js',
  keywords: [
    'loggly-jslogger',
    'jslogger',
    'loggly',
    'log'
  ],
  authors: [
    'Loggly'
  ],
  license: 'MIT',
  ignore: [
    '**/.*',
    'node_modules',
    'bower_components',
    'test',
    'tests'
  ]
}

No versions available.
davidgovea commented 9 years ago

From bower's bower.json docs

version String Deprecated. Use git or svn tags instead. This field is ignored by Bower.

davidgovea commented 9 years ago

ping ping - would love a proper release!

varshneyjayant commented 9 years ago

@davidgovea I will update today :)

varshneyjayant commented 9 years ago

@davidgovea @ppcano @sirsgriffin @barlindhaug

Proper release tags are pushed in repo. You can see the versions now with bower info loggly-jslogger

$ bower info loggly-jslogger
bower loggly-jslogger#*         cached git://github.com/loggly/loggly-jslogger.git#3.0.0
bower loggly-jslogger#*       validate 3.0.0 against git://github.com/loggly/loggly-jslogger.git#*

{
  name: 'loggly-jslogger',
  homepage: 'https://github.com/loggly/loggly-jslogger',
  version: '3.0.0',
  description: 'A Javascript client to send logs to Loggly.',
  main: 'src/loggly.tracker.js',
  keywords: [
    'loggly-jslogger',
    'jslogger',
    'loggly',
    'log'
  ],
  authors: [
    'Loggly'
  ],
  license: 'MIT',
  ignore: [
    '**/.*',
    'node_modules',
    'bower_components',
    'test',
    'tests'
  ]
}

Available versions:
  - 3.0.0
  - 2.0.0
You can request info for a specific version with 'bower info loggly-jslogger#<version>'
davidgovea commented 9 years ago

@psquickitjayant thank you!

also, thanks for getting full-on tags implemented recently :+1: