search

loggly / node-loggly-bulk

A client implementation for Loggly in node.js
https://www.loggly.com/docs/node-js-logs/
Other
20 stars 20 forks source link

Clear timerFunctionForBufferedLogs if not needed #14

Closed btamayo closed 7 years ago

btamayo commented 7 years ago

This is an example of a fix for https://github.com/loggly/winston-loggly-bulk/issues/12 with a small amount of code change.

Please note that these lines in common.js:

https://github.com/loggly/node-loggly-bulk/blob/ea918224b6a88123cb73dda0227cb25a207c2170/lib/loggly/common.js#L205-L210

produce the same bug when isBulk is true.

See https://github.com/loggly/winston-loggly-bulk/issues/13. This PR does not address that just in case you would like to implement a better timing solution than using setInterval. I would consider this fix temporary if merged.

Thanks!

mostlyjason commented 7 years ago

I believe this was merged in #16. Closing this PR.