loggly / node-loggly-bulk

A client implementation for Loggly in node.js
https://www.loggly.com/docs/node-js-logs/
Other
20 stars 19 forks source link

Resolve callback error and modified the entire retry logic #34

Closed Shwetajain148 closed 6 years ago

Shwetajain148 commented 6 years ago

@mchaudhary @mostlyjason In this PR, I have modified the entire error retry logic and have covered the below points:

Also, I took a reference of retry logic from here: https://github.com/logzio/logzio-nodejs/blob/master/lib/logzio-nodejs.js#L248-L258.

I checked the library behavior after these changes in a continue logging environment for about 8 hours and did not see any callback error. The issue is related to https://github.com/loggly/winston-loggly-bulk/issues/13.

Update: I also tested the library code in both bulk & input mode for 15 days in a continue event logging environment. My node application did not break with any error.

Please review the changes.

eduard-piliposyan commented 6 years ago

Any ETA when this will be merged ? We have error Callback was already called. and will be very happy to see this issue fixed.

wlindley commented 6 years ago

Same here, we'd love to see this merged!

dmr-loggly commented 6 years ago

Hey everyone, we apologize for the delay in processing this PR. I'm working right now on making sure it's brought to the right people's attention to be fixed ASAP.

matthewchng commented 6 years ago

@mchaudhary Will there be a patch version bump to release this change? The current version 2.2.1 was updated 3 months ago. Thanks.

node-loggly-bulk version