search

logic-and-learning-lab / Popper

An inductive logic programming system
MIT License
206 stars 36 forks source link

Added windows support #78

Open Mohammadsaknini opened 12 months ago

Mohammadsaknini commented 12 months ago

Singnal is only partially supported under windows, so i created the timeout function using threads instead of singals which should work on windows as an alternative.

Mohammadsaknini commented 3 weeks ago

Tbh its been a while, but i do think it is indeed a typo. Probably forgot to remove it while fiddling around with the code.

peterasa commented 3 weeks ago

I've tested the code and it does work on Windows. There were some further modifications needed on loop.py though, due to a similar timeout construct occuring in it without calling the util.py/timeout function.

Kudos for the fix, it really helped me. Thanks! 👍