search

logicahealth / covid-19

COVID-19 / SARS-CoV-2 FHIR Profiles Implementation Guide (IG)
https://covid-19-ig.logicahealth.org
17 stars 9 forks source link

Recommend adding an includes/menu.xml file to improve navigability #15

Open saulakravitz opened 4 years ago

saulakravitz commented 4 years ago

Submitted a pull request with a menu that should work. I can't get the build process to work on my laptop (running out of heap space despite reconfiguring docket desktop),...

preston commented 4 years ago

@neuronsong Could you take a look at this? I'm not familiar with it.

neuronsong commented 4 years ago

Are you doing a docker build... or running the publisher manually? If you're running the publisher manually I have had good success with the following: java -Xss1g -Xms2g -Xmx4g -jar org.hl7.fhir.igpublisher.jar -ig .

I'm taking a look at the changes now.

neuronsong commented 4 years ago

I just built the branch... and the menu is not working. The menu is broken visually and throwing off 404 errors.

preston commented 4 years ago

For Docker builds, the docker build ... needs a --memory=4g switch, as well as the daemon allowed to malloc at least that amount. For macOS and Windows, this is globally set in the UI settings panel.

saulakravitz commented 4 years ago

BUilding successfully with java directly. SHould have a new pull request that actually works shortly. Thanks for your patience.

From: Preston Lee notifications@github.com Sent: Thursday, April 23, 2020 5:39 PM To: logicahealth/covid-19 covid-19@noreply.github.com Cc: Kravitz, Saul A. saul@mitre.org; Author author@noreply.github.com Subject: [EXT] Re: [logicahealth/covid-19] Recommend adding an includes/menu.xml file to improve navigability (#15)

For Docker builds, the docker build ... needs a --memory=4g switch, as well as the daemon allowed to malloc at least that amount. For macOS and Windows, this is globally set in the UI settings panel.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/logicahealth/covid-19/issues/15#issuecomment-618686180, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI36FE4V7JHMOZM4HWVN733ROCYSDANCNFSM4MNRC7JA.

saulakravitz commented 4 years ago

Still can't build....how does one get the ig build tool to NOT run sushi...it keeps clobbering my menu.xml file. I've committed the correct one, with correct links to the relevant subsections of the IG that should be of interest to a reader. I can't get it to build, but there is not a lot there to go wrong (famous last words).

From: Kravitz, Saul A. saul@mitre.org Sent: Thursday, April 23, 2020 6:34 PM To: logicahealth/covid-19 covid-19@noreply.github.com; logicahealth/covid-19 reply@reply.github.com Cc: Author author@noreply.github.com Subject: Re: [EXT] Re: [logicahealth/covid-19] Recommend adding an includes/menu.xml file to improve navigability (#15)

BUilding successfully with java directly. SHould have a new pull request that actually works shortly. Thanks for your patience.

From: Preston Lee notifications@github.com Sent: Thursday, April 23, 2020 5:39 PM To: logicahealth/covid-19 covid-19@noreply.github.com Cc: Kravitz, Saul A. saul@mitre.org; Author author@noreply.github.com Subject: [EXT] Re: [logicahealth/covid-19] Recommend adding an includes/menu.xml file to improve navigability (#15)

For Docker builds, the docker build ... needs a --memory=4g switch, as well as the daemon allowed to malloc at least that amount. For macOS and Windows, this is globally set in the UI settings panel.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/logicahealth/covid-19/issues/15#issuecomment-618686180, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI36FE4V7JHMOZM4HWVN733ROCYSDANCNFSM4MNRC7JA.

preston commented 4 years ago

If it detects the fsh source directory it automatically runs. Is this something that needs to be fixed in the IG publisher?

saulakravitz commented 4 years ago

Got it working. They key is DELETING the input/* and output directories prior to each run of the Java code. I've built and tested the menu. It ain't perfect, but it works. Give it a whirl!

From: Preston Lee notifications@github.com Sent: Friday, April 24, 2020 10:54 AM To: logicahealth/covid-19 covid-19@noreply.github.com Cc: Kravitz, Saul A. saul@mitre.org; Author author@noreply.github.com Subject: [EXT] Re: [logicahealth/covid-19] Recommend adding an includes/menu.xml file to improve navigability (#15)

If it detects the fsh source directory it automatically runs. Is this something that needs to be fixed in the IG publisher?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/logicahealth/covid-19/issues/15#issuecomment-619060607, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI36FE7VHXVPBVZJ6OHNA4TROGR3PANCNFSM4MNRC7JA.