search

logicahealth / vha-kbs-knarts

VHA Knowledge-Based Systems clinical knowledge artifact content development program.
Apache License 2.0
7 stars 3 forks source link

Use of composite trigger condition with existing KNART conditions. #133

Open preston opened 6 years ago

preston commented 6 years ago

Is there an established rule for how triggers should be interpreted when referenced artifacts also have conditions? I would assume that either:

  1. Iff trigger conditions are identified in the composite declaration, entry conditions (XPath: /knowledgeArtifact/conditions) within a KNART are ignored, or,
  2. Both composite trigger conditions and KNART conditions are evaluated, in that order.
preston commented 6 years ago

Per Jerry on May 14th, 2018, it is the latter. In other words, the trigger condition triggers evaluation of the referenced conditions, and neither ignores them nor guarantees a "true" result. Thus, is it insufficient to review only triggers/handlers at the composite level -- you must also open referenced artifacts and reviews criteria at that level, as well.

preston commented 6 years ago

@kthlnkeating Is this the spreadsheet we should be using for HL7 comments specifically regarding composites? https://docs.google.com/spreadsheets/d/1m8BUTQhAcdRQcIxueN_VL6tOXmRM-23pCe0JxELIWdI/edit#gid=2117819774

preston commented 6 years ago

I'll close this out after feedback has been entered in the correct location.

kthlnkeating commented 6 years ago

Confirming location currently...will provide update once received.

kthlnkeating commented 6 years ago

The spreadsheet at the link above is tracking the issues our team is seeing/having with the KAS standard and is not specific to composite. The majority of those issues noted have been registered as change requests or comment feedback at HL7 against the standard. Those can be seen here:

http://www.hl7.org/dstucomments/showdetail.cfm?dstuid=156