search

logicahealth / vha-kbs-knarts

VHA Knowledge-Based Systems clinical knowledge artifact content development program.
Apache License 2.0
7 stars 3 forks source link

Document title mismatch #153

Open scottdwood opened 6 years ago

scottdwood commented 6 years ago

https://github.com/preston/vha-kbs-knarts/blob/6c40e642d537ca36a67ad958ab768c9bc3e91aa4/content/cardiology_electrophysiology_ep_implanted_cardiac_device/b9/CDSK_KRprt_OS_B9EPICDImp.xml#L42

The title page of the conceptual structure document is missing the preface "Cardiology:", so there is not an exact match between the document title and the reference in the XML document.

a-dru-desai commented 6 years ago

@scottdwood - Please compare CSD with Line 20 of the XML.

scottdwood commented 6 years ago

Ok, that's wrong too. The OS title should have the broader category "Cardiology:" prepended. Still, the title on line 42 does not match the title of the referenced document. A human can figure this out but a computer may stumble.

WendelynB commented 6 years ago

Cardiology is missing from the Title Value of the original CCWP. The rest of the tags appear correct.

<p>Add Cardiology to Title Value of original CCWP.<br /> Backlog</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/kthlnkeating"><img src="https://avatars.githubusercontent.com/u/1321935?v=4" />kthlnkeating</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Returning issue to PO.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/a-dru-desai"><img src="https://avatars.githubusercontent.com/u/38264619?v=4" />a-dru-desai</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>@WendelynB @kthlnkeating When you say "original CCWP" do you mean the final approved version that Scott is using for his review or (as I interpret it) an earlier version pre-review/edits/revisions? </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/csp4z"><img src="https://avatars.githubusercontent.com/u/39007008?v=4" />csp4z</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>This issue of title not reflecting the clinical domain (e.g. Cardiology) has been addressed in the validation scripts and will be reflected in the redelivered version of this KNART set. CDS_Fix</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/preston"><img src="https://avatars.githubusercontent.com/u/21615?v=4" />preston</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Sounds like it's fixed. Either way, given recent changes to the review process I am triaging this to the backlog per adjudication conversation with @a-dru-desai and @kbsgitgal as to not affect approval.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>