search

logicahealth / vha-kbs-knarts

VHA Knowledge-Based Systems clinical knowledge artifact content development program.
Apache License 2.0
7 stars 3 forks source link

Artifact file reference name and type mismatches. #313

Closed preston closed 6 years ago

preston commented 6 years ago

"CDSK_KRprt_CRDT_B35CardPreOp.xml" is known as "CDSK_KRprt_CRDT_B35CPCAD.XML" in the actual repository, but I don't think this matters because it appears to be a completely unrelated KNART? This file is actually referenced in both the composite and HIMKWP. I'm not sure what's going on, but it looks like this may be incorrect in both the composition KNART and the HIMKWP, because B13 -- the KNART actually noted as the order set -- doesn't appear to actually be invoked.

https://github.com/preston/vha-kbs-knarts/blob/62e729e0aae112b4848edc15a35d8581a291b282/content/cardiology_preop_risk_assessment/b58/CDSK_KRprt_CRCK_B58CardPreOp.xml#L97

You can more easily see the lack of usage of B13 in the diagram:

https://github.com/preston/vha-kbs-knarts/blob/master/content/cardiology_preop_risk_assessment/b58/CDSK_KRprt_CRCK_B58CardPreOp.xml.svg

Similarly, "CDSK_KRprt_OS_B37CardPreOp.xml" is actually "CDSK_KRprt_CRDT_B37CardPreOp.xml":

https://github.com/preston/vha-kbs-knarts/blob/62e729e0aae112b4848edc15a35d8581a291b282/content/cardiology_preop_risk_assessment/b58/CDSK_KRprt_CRCK_B58CardPreOp.xml#L164

The file naming issue is minor, but any missing or erroneous references do need to be fixed. Once things are wired correctly let me know!

a-dru-desai commented 6 years ago

@kthlnkeating Please review Preston's comments.

csp4z commented 6 years ago

Tagging CDS_Fix while we investigate.

csp4z commented 6 years ago

Confirmed that this is CDS_Fix.

preston commented 6 years ago

Thanks. Note that fix(es) may require changes to multiple documents such as the HIMKWP, not just KNART XML.

csp4z commented 6 years ago

Addressed in authoring. Waiting delivery to VA.

kthlnkeating commented 6 years ago

Revised files delivered 6/22.

preston commented 6 years ago

@JuanitaMathis Could you make sure these are available? I'm not seeing the updates to this one.

JuanitaMathis commented 6 years ago

@a-dru-desai Please see above comment & confirm if possible. Kathleen did not send me the revisions, so I cannot verify the related file has updates.

csp4z commented 6 years ago

Updated files were uploaded 5 days ago. The are the ones prefixed with "Revised...."

https://github.com/preston/vha-kbs-knarts/tree/master/content/cardiology_preop_risk_assessment/b58

preston commented 6 years ago

Diff reviewed manually. Issue appears fixed in most recent revised copy.