search

logicahealth / vha-kbs-knarts

VHA Knowledge-Based Systems clinical knowledge artifact content development program.
Apache License 2.0
7 stars 3 forks source link

Obviously invalid XML. #338

Closed preston closed 6 years ago

preston commented 6 years ago

@kthlnkeating Please, please make sure XML deliverables are valid after whatever post-production changes are being made. This is a clear syntactic error that would be caught with even the most primitive tools. As this has happened numerous times now, it's apparent that nothing is being done to prevent errors from being added after the validation reports are run. I understand there are likely rational process reasons for these manual edits, but it is extremely concerning that we can't rely on the validation reports as a result.

https://github.com/preston/vha-kbs-knarts/blob/5e1c1fd07d31384ca41ce3f93b72fdd6f36bcfbf/content/mental_health_postdeployment/o3/CDSK_KRprt_ECA_O3IraqAfghanPD.xml#L21

I'm breaking protocol and directly applying a "CDS_Fix" label on this.

preston commented 6 years ago

@kthlnkeating Could we get an ETA on this? At present it's still not well formed, so it's impossible that this is the KNART that was actually validated.

csp4z commented 6 years ago

Addressed in authoring. Waiting delivery to VA.

preston commented 6 years ago

Thanks -- awaiting receipt.

kthlnkeating commented 6 years ago

Revised files delivered 6/22.

preston commented 6 years ago

Diff reviewed manually. Fixed in revised copy.