search

logicahealth / vha-kbs-knarts

VHA Knowledge-Based Systems clinical knowledge artifact content development program.
Apache License 2.0
7 stars 3 forks source link

Incorrect/Duplicate invocation of b46 (documentation template) from b67 (composite). #339

Closed preston closed 6 years ago

preston commented 6 years ago

This looks incorrect:

https://github.com/preston/vha-kbs-knarts/blob/5589c8ea0cbed85dbc6609c3b9b887d69fc82111/content/mental_health_consult_for_depression/b67/CDSK_KRprt_CRCK_B67DepConsul.xml#L123

You can visually see the issue in this rendering, where it appears as a directed edge that automatically emits a ConsultInfoCompleteEvent:

https://github.com/preston/vha-kbs-knarts/blob/master/content/mental_health_consult_for_depression/b67/CDSK_KRprt_CRCK_B67DepConsul.xml.svg

preston commented 6 years ago

The correct invocation already appears at: https://github.com/preston/vha-kbs-knarts/blob/5589c8ea0cbed85dbc6609c3b9b887d69fc82111/content/mental_health_consult_for_depression/b67/CDSK_KRprt_CRCK_B67DepConsul.xml#L186

a-dru-desai commented 6 years ago

@kthlnkeating For review

csp4z commented 6 years ago

Addressed in authoring. Waiting delivery to VA. Removed extra onCompletion fire event action on line 121

kthlnkeating commented 6 years ago

Revised files delivered 6/26.