logicahealth / vha-kbs-knarts

VHA Knowledge-Based Systems clinical knowledge artifact content development program.
Apache License 2.0
7 stars 3 forks source link

Neurology: Traumatic Brain Injury (TBI) Composite KNART (b62) #341

Closed a-dru-desai closed 6 years ago

a-dru-desai commented 6 years ago

Preston - another composite KNART -

https://github.com/preston/vha-kbs-knarts/tree/master/content/neurology_tbi_screening/b62

preston commented 6 years ago

@kthlnkeating This loop doesn't look right. https://github.com/preston/vha-kbs-knarts/blob/master/content/neurology_tbi_screening/b62/CDSK_KRprt_CRCK_B62TBI.xml.svg

Assigning directly to @cp4cms.

csp4z commented 6 years ago

Addressed in authoring. Waiting delivery to VA. Removed circular dependency by deleting entire simple action on line 167

preston commented 6 years ago

@cp4cms Are you sure? Here is what the revised looks like:

https://github.com/preston/vha-kbs-knarts/blob/master/content/neurology_tbi_screening/b62/20180626REVISED-CDSK_KRprt_CRCK_B62TBI.xml.svg

csp4z commented 6 years ago

@preston Agree with your assessment. We have fixed this in the attached file. Take a look and let us know if this is OK and we will submit it formally to the VA to replace the existing one. CDSK_KRprt_CRCK_B62TBI.xml.zip

csp4z commented 6 years ago

New fixes seem correct per meeting with @preston - Will deliver formal delivery today.

preston commented 6 years ago

@a-dru-desai The version attached by @cp4cms seems to have the issue resolved.