Closed preston closed 5 years ago
I am going to wait until I give you final, approved documents before I review these. Final approval has not happened yet, although I reached out for it 10/31.
@linophth Going forward, are these "final" approvals based on your annotated copy, or a revised copy produced from myself, you, or others?
I'll send you an annotated copy of the final, approved document but we both agreed that "final" approval will occur when I review the revised copy produced by you.
Sounds good. I've asked @ssebast2 to stage these in the interim via email.
@Fcuello I'm seeing some changes to lumbarthoracic from you last week, but not any to cervical. Is that correct?
@Fcuello Actually I think I may be confused or made a packaging error. Could you check the PDF version and verify that your changes are present? https://github.com/OSEHRA/vha-kbs-knarts/blob/master/content/neurosurgery_cervical_radiculopathy/CDSK_CCWP_B15B39B60CervRadi.pdf
When I tried to push this back up git bash said it was up to date. I assume these were updated by someone other than me and they forgot to make a note.
I did not make any recent changes in these documents.
@preston I just checked, there was only one edit on the SME version of the word doc and it is reflected on the rendered pdf version. I think we are ok on this one.
@Fcuello Ok cool -- I wasn't sure if these were current on CDS Connect so I manually updated the files there just in case. CC @ssebast2
Completed.
20180430REVISED-CDSK_CCWP_B15B39B60CervRadi_final_508_KBS_APPROVED_LLW_V2.docx 20180502REVISED-CSDK_CCWP_B16B40B61LTRadi_final_508_KBS_APPROVED_LLW_V2.docx
The attached Word files were provided by @linophth as changes to the neurosurgery cervical radiculopathy and lumbarthoracic radiculopathy whitepapers. Prior to making changes I did a manual diff across the existing Word documents, and there are changes included in the cervical paper that for whatever reason do NOT appear in the "track changes" log of Word. In making changes to the DocBook XML files, I have gone off the manual diff in lieu of relying on the Word change log. This is pretty painful and we'll need to improve this process moving forward.