logicahealth / vha-kbs-knarts

VHA Knowledge-Based Systems clinical knowledge artifact content development program.
Apache License 2.0
7 stars 3 forks source link

Neurology: Traumatic Brain Injury (TBI) - Missing Usage, Source and References #463

Open ssebast2 opened 5 years ago

ssebast2 commented 5 years ago

@linophth @preston I apologize for all the GitHub entries. I think that once we get over the hump with a handful of artifacts the rest will be a breeze. The issues that are arising are consistent, so we just need to figure out an approach moving forward.

It seems like the mulitmodal artifacts tend to be without Usage, Source, and References. This is probably because they are really comprised of several artifacts. For clarity, I suggest that we still populate these 3 fields for viewers who go directly to a multimodal artifact, instead of looking at all of the components first.

I would be happy to populate the Usage details based upon what is listed in the White Paper, add the primary source (e.g., Derived from xxx White Paper) and the References that are associated with each group of artifacts. Please let me know if you would like me to proceed or wait to have you update the XML then reload the multimodal artifacts via the API.

I don't mind making the updates - they are easy, but I don't want to interfere with your process.

Thanks, Sharon

linophth commented 5 years ago

I would love it if you made the updates, since the learning curve would slow me down. Let's see if Preston agrees

ssebast2 commented 5 years ago

@preston Is it okay if I go ahead and manually add Source and Reference entries to the TBI and Neurosurgery artifacts so I can get them published?

Moving forward, for artifacts not already uploaded to the Repository, we can revisit the workflow (i.e., you can update the XML and re-upload if you prefer or I can manually add the Source and Reference). Just let me know your preference.

Thanks!

linophth commented 5 years ago

I think we need to let Preston make the call on technical workflow – I’m happy with whatever he decides.

linophth commented 5 years ago

I think we need to let Preston make the call on technical workflow – I’m happy with whatever he decides.

ssebast2 commented 5 years ago

Roger that. I am happy to do whatever is decided.

ssebast2 commented 5 years ago

@preston Just checking back on how you would like me to proceed with regard to these multimodal artifacts. They are still pending publishing. Thanks!

ssebast2 commented 5 years ago

@preston Is it okay if I go ahead and manually add Source and Reference entries to the TBI and Neurosurgery artifacts so I can get them published?

Moving forward, for artifacts not already uploaded to the Repository, we can revisit the workflow (i.e., you can update the XML and re-upload if you prefer or I can manually add the Source and Reference). Just let me know your preference.

preston commented 5 years ago

@ssebast2 If you want to edit the white paper XML (not the Word or PDF copy directly), either on master or via a pull request (PR), myself or @fcuello can rerender the PDFs that CDS Connect posts. As long as @linophth is ok with the changes themselves I am good with you making the XML changes!

ssebast2 commented 5 years ago

@preston I am proposing that I type an entry "response" in to the repository Source and Reference fields. The responses would align with what is in the white paper. If I do this, there is no need to adjust the XML at all. It is a work around to finish up the 3 multi-modal artifacts that are pending publishing.

I am requesting approval for me to manually add metadata responses. That is a quick, easy and accurate approach to the concern. However, if you prefer that the XML upload file be the source of truth for the multi-modal artifact uploads, then we will need someone to add responses for these fields. I am open to either approach. Just let me know.

If it is easier to discuss over the phone, my work cell is: 703-872-9757. I am free this afternoon, except between 3-4pm ET. Thanks!!

preston commented 5 years ago

@Fcuello Could you take a look at this?