Open AJH16 opened 9 years ago
Thank you for the push. I will refactor your classes and add to rep soon. Also, can you add please unit testing for your classes?
I was looking at the unit tests but wasn't sure what was needed. Sadly my php skills are a bit rusty.
Sent from my Verizon Wireless 4G LTE smartphone
-------- Original message -------- From: And notifications@github.com Date:04/29/2015 10:48 AM (GMT-05:00) To: logical-and/php-oauth php-oauth@noreply.github.com Cc: AJH16 ajh16@nycap.rr.com Subject: Re: [php-oauth] Add Battle.Net Services (#19)
Thank you for the push. I will refactor your classes and add to rep soon. Also, can you add please unit testing for your classes?
— Reply to this email directly or view it on GitHub.
:), ok I understand. I will add tests too.
Hey @AJH16. Can you please validate refactored BattleNet service. Also, I need a valid credentials to write an example and test it, can you please provide it to me?
I will look in to it but I'm not sure that there are any sample credentials available. For limited testing a new account should work but I'm not directly affiliated with BattleNet so they might shut down such an account. I do have a friend on the api team there though, so I will check with him about it.
Sent from my Verizon Wireless 4G LTE smartphone
-------- Original message -------- From: And notifications@github.com Date: 05/26/2015 2:25 PM (GMT-05:00) To: logical-and/php-oauth php-oauth@noreply.github.com Cc: AJH16 ajh16@nycap.rr.com Subject: Re: [php-oauth] Add Battle.Net Services (#19)
Hey @AJH16. Can you please validate refactored BattleNet service. Also, I need a valid credentials to write an example and test it, can you please provide it to me?
— Reply to this email directly or view it on GitHub.
@AJH16 any news on this?
Not yet, my contact has been pretty busy. I'll let you know as soon as I know anything more.
Sent from my Verizon Wireless 4G LTE smartphone
-------- Original message -------- From: And notifications@github.com Date: 05/28/2015 3:33 PM (GMT-05:00) To: logical-and/php-oauth php-oauth@noreply.github.com Cc: AJH16 ajh16@nycap.rr.com Subject: Re: [php-oauth] Add Battle.Net Services (#19)
@AJH16 any news on this?
— Reply to this email directly or view it on GitHub.
Ok, test@firstregimentguild.com and phpuser123 are now valid credentials for the oAuth. I don't have an API key configured as those have to be tied to the specific callback address you are using (which also has to be an SSL secured URL.
@AJH16 Security question/code?
Figures. I'll set a security question for it or see if I can disable the check.
Sent from my Verizon Wireless 4G LTE smartphone
-------- Original message -------- From: And notifications@github.com Date: 06/12/2015 2:54 PM (GMT-05:00) To: logical-and/php-oauth php-oauth@noreply.github.com Cc: AJH16 ajh16@nycap.rr.com Subject: Re: [php-oauth] Add Battle.Net Services (#19)
@AJH16 Security question/code?
— Reply to this email directly or view it on GitHub.
Ok, I waiting for it.
ok, do the question and the answer is "wow" for the security question.
were you able to get past the check?
Hey @AJH16, just was a busy. I added an example to /examples, but when I tested how a service works I found an error. Here is what Battle.Net service returns:
error:invalid_request error_description:Internal server error
Can you please test a service and fix it, if it contains an error?
This can probably be cleaned up a bit, but I wasn't sure how. Each region uses the same syntax and pattern, however all URIs have a different sub-domain. I implemented it as a base class and overrides for the region, but ideally it should be a single class that can take a region setting. I wasn't sure how to tackle such a thing consistent with the architectural objectives of the project though.