search

logical-and / php-oauth

Support for authenticating users (without dep from any framework) using both OAuth1 and OAuth2 methods
https://packagist.org/packages/and/oauth
MIT License
43 stars 13 forks source link

PSR-2 #23

Closed rtheunissen closed 9 years ago

rtheunissen commented 9 years ago

Would you consider changing to PSR-2? While working on the pull request for #21 I couldn't help but notice gross indentation inconsistencies and I believe that this project would benefit greatly from following a framework standard such as PSR-2 (as it already applies PSR-4).

A few obvious things that would need to be updated are:

logical-and commented 9 years ago

Well, sounds like good idea. I will take a care about coding standard soon. Thank you :)

rtheunissen commented 9 years ago

I will take a care about coding standard soon.

I'd be happy to do it and create a pull request?

logical-and commented 9 years ago

Yes, it will be a great help for us all, if you do it. :) If you working in PHPStorm, then you can use PSR-1/PSR-2 from predefined styles, and apply that style to all files.

logical-and commented 9 years ago

@rtheunissen Please look on updated code, is it the fresh psr-2? :)