logicalclocks / maggy

Distribution transparent Machine Learning experiments on Apache Spark
https://maggy.ai
Apache License 2.0
89 stars 14 forks source link

experiment driver refactor #93

Closed amacati closed 3 years ago

amacati commented 3 years ago

Refactors the execution drivers to include all lagom logic. Removes lagom functions for the experiments.

Last PR of the overall Maggy refactoring. Removes the redundancies in the separate lagom functions. The experiment now only creates the experiment driver, which takes care of the details of each implementation.

Main changes:

Where possible, arguments were reduced to APP_ID and RUN_ID. We had a whole variety of arguments such as log_dir names etc that are calculated from the app_id /run_id. Passing/keeping track of all those arguments is rather tedious, so I began to use app_id/run_id whereever possible to make things as simple as possible.

Misc: